Skip to content

Add preliminary calculations fields for 252, 259 and 260 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Guzz-T wants to merge 2 commits into
base: main
Choose a base branch
from
+43 −0
Open

Add preliminary calculations fields for 252, 259 and 260 #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5ab3e
Add preliminary calculations fields for 252, 259 and 260
Guzz-T Mar 15, 2026
ab13f2b
Add new fields to the test_compatibility.py
Guzz-T Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions luxtronik/definitions/calculations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2638,6 +2638,16 @@
"unit": '',
"description": '',
},
{
"index": 252,
"count": 1,
"names": ['ID_WEB_Temperatur_THG_max'],
"type": Celsius,
"writeable": False,
"datatype": 'UINT32',
"unit": '',
"description": 'TODO: Provisional new description based on #180',
Copy link
Collaborator

@kbabioch kbabioch Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to merge it like this, or this this something you want to do before merging it?

Copy link
Contributor Author

@Guzz-T Guzz-T Mar 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to wait for a reply from @dasSofa to see if the description is correct. Then I’ll merge it and remove the TODO from the description later if everything is in ok and the open points from #180 are done.

},
{
"index": 252,
"count": 1,
Expand Down Expand Up @@ -2714,6 +2724,22 @@
"unit": '',
"description": '',
},
{
"index": 259,
"count": 1,
"names": ['cooling_active'],
"type": Bool,
"writeable": False,
"datatype": 'UINT32',
"unit": '',
"description": (
"Pin 9 on the main board. "
"Signal to the room thermostat to switch between heating and cooling. "
"If the expansion board is installed, "
"this signal comes from calculation 140 `ID_WEB_FP3out`.\n\n"
"TODO: Provisional new description based on #180"
)
},
{
"index": 259,
"count": 1,
Expand All @@ -2724,6 +2750,19 @@
"unit": '',
"description": '',
},
{
"index": 260,
"count": 1,
"names": ['ID_WEB_Time_ena_cooling'],
"type": Seconds,
"writeable": False,
"datatype": 'UINT32',
"unit": '',
"description": (
"Time in seconds until cooling is enabled\n\n"
"TODO: Provisional new description based on #180"
)
},
{
"index": 260,
"count": 1,
Expand Down
4 changes: 4 additions & 0 deletions tests/test_compatibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,6 +1617,10 @@ def test_compatibilities(self):
"Unknown_Calculation_272": (272, Unknown),
"Unknown_Calculation_273": (273, Unknown),
"Unknown_Calculation_274": (274, Unknown),
# New in 'main' branch (after next release):
"ID_WEB_Temperatur_THG_max": (252, Celsius),
"cooling_active": (259, Bool),
"ID_WEB_Time_ena_cooling": (260, Seconds),
}

visis = {
Expand Down
Loading