Skip to content

Update data fields of the “energy” and “voltage” types#264

Open
Guzz-T wants to merge 5 commits intoBouni:mainfrom
Guzz-T:issue/198/datatypes
Open

Update data fields of the “energy” and “voltage” types#264
Guzz-T wants to merge 5 commits intoBouni:mainfrom
Guzz-T:issue/198/datatypes

Conversation

@Guzz-T
Copy link
Contributor

@Guzz-T Guzz-T commented Mar 17, 2026

  • Change the scaling factor of 'ID_Waermemenge' parameters from 0.1 to 0.01
  • Change the scaling factor of the voltage data type to 0.01

Relates to #198

@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __main__.py25250%3–66
   datatypes.py454199%147
   discover.py58198%63
luxtronik/cfi
   interface.py175398%167–168, 256
luxtronik/definitions
   __init__.py208199%216
luxtronik/scripts
   __init__.py35586%7–16, 51
   discover_shi.py60600%8–98
   dump_cfi.py14657%18–25, 29
   dump_shi.py15660%21–28, 32
   performance_shi.py63630%7–89
   update_screen.py1058222%6, 20–41, 46–48, 51–61, 64, 70–75, 78, 81–85, 88–92, 95–97, 100–103, 106–111, 115–116, 119–126, 129–136
   watch_cfi.py321650%36–47, 50–56, 60
   watch_shi.py331652%38–49, 52–58, 62
luxtronik/shi
   interface.py337399%438, 519, 527
TOTAL243628888% 

Tests Skipped Failures Errors Time
381 0 💤 0 ❌ 0 🔥 17.971s ⏱️

@Guzz-T Guzz-T force-pushed the issue/198/datatypes branch from 92b0a32 to 3fd1379 Compare March 17, 2026 20:49
@Guzz-T Guzz-T closed this Mar 17, 2026
@Guzz-T Guzz-T reopened this Mar 17, 2026
@Guzz-T Guzz-T changed the title Issue/198/datatypes Update data fields of the “energy” and “voltage” types Mar 17, 2026
@Guzz-T
Copy link
Contributor Author

Guzz-T commented Mar 17, 2026

Can any of you check the values on your heat pump?

Copy link
Collaborator

@kbabioch kbabioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks fine to me, but let's give this some time to verify whether it fixes the issue in the real world :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants