Skip to content

Constrain BitfieldChangedCallback value params to clarify intent somewhat #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garethpotter merged 1 commit into from
Apr 3, 2026
Merged

Constrain BitfieldChangedCallback value params to clarify intent somewhat #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Modspec.Model/IModbusClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ namespace Modspec.Model;
/// Callback invoked when a bitfield point with level annotations changes between reads.
/// </summary>
/// <param name="name">The name of the bitfield point that changed.</param>
/// <param name="oldValue">The previous value of the bitfield (boxed enum).</param>
/// <param name="newValue">The current value of the bitfield (boxed enum).</param>
/// <param name="oldValue">The previous value of the bitfield.</param>
/// <param name="newValue">The current value of the bitfield.</param>
/// <param name="level">The highest severity level among the currently set flags.</param>
public delegate void BitfieldChangedCallback(string name, object oldValue, object newValue, Level level);
public delegate void BitfieldChangedCallback(string name, Enum oldValue, Enum newValue, Level level);

/// <summary>
/// Interface for a Modbus client.
Expand Down
Loading