[IMPROVEMENT]: Add ATSC XMLTV regression test coverage via Alembic migration#1003
Open
x15sr71 wants to merge 9 commits intoCCExtractor:masterfrom
Open
[IMPROVEMENT]: Add ATSC XMLTV regression test coverage via Alembic migration#1003x15sr71 wants to merge 9 commits intoCCExtractor:masterfrom
x15sr71 wants to merge 9 commits intoCCExtractor:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
Add regression test coverage for ATSC XMLTV output generation (
--xmltv=1) using the ATSC broadcast sample I uploaded to the platform.This test exercises:
expected_rc=10) withOutputType.nullTechnical Details
Sample Selection
Sample 187 (
ch29FullTS.ts) – ATSC broadcast sample for XMLTV testing with--xmltv=1 --out=null:6b10f8aef895469ec9cb89ecd0c2463eb2442052c32da9d81c6a6f5cec9137b8I reviewed the TS samples currently available on the platform and did not find any that contain the ATSC PSI/SI tables (VCT, EIT, ETT) needed to exercise the ATSC XMLTV generation paths. For this reason, I recently added an ATSC broadcast sample to provide regression coverage.
Database Deployment Strategy
Following the pattern from the WebVTT PR (#993):
install/sample_db.pytests/base.pyfixturesWhy no test fixture changes:
Test Characteristics
Migration Details
eb7303e132c0c8f3a2b1d4e5(latest migration on master)Related Work