Open
Conversation
GauriRajesh733
requested changes
Mar 21, 2026
Collaborator
GauriRajesh733
left a comment
There was a problem hiding this comment.
looks really good!! im just thinking if we should have one route for filtering and sorting that takes in all criteria at once so that we don't need separate methods for each (something like AnthologyFilterDto and AnthologySortDto). i know initially in the ticket description these methods were separated so lmk if you have any questions or you think the current approach is more appropriate!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #109
📝 Description
Did a bit of bug bashing to run the backend. Not sure if it was running on your end, but after pulling from main I made the following changes:
There was also a preexisting linting error for importing to the backend from the frontend. I disabled it for now with a // eslint* comment, unsure how you want to handle this.
EDIT AFTER PR REVIEW: Updated from 7 endpoints to 1 centralized endpoint to sort and filter. /filter-sort. Tested w/ no filters passed in, almost all of them passed in, and some in isolation. Also tested a case where an empty list was returned. Great callout from @GauriRajesh733 to change to this approach. Made all fields optional, thought it would have good ease of use for consumers of the service. Undefined/[] cases are handled in the service method.
P.S. if you have trouble running the tests I had to regenerate my lock file, didn't commit it but if that is an issue on your end that is probably the solution.