Open
Conversation
amywng
requested changes
Mar 24, 2026
| years?: number[], | ||
| page = 1, | ||
| ): Promise<PantryStats[]> { | ||
| const PAGE_SIZE = 10; |
Member
There was a problem hiding this comment.
i know the ticket says do 10 pantries per page, but thoughts on changing PAGE_SIZE here to 9 and then also on the page to have it match the figma
Author
There was a problem hiding this comment.
total stats is only supposed to be on the first page i just found out, so it will be 9 on the first, 10 on the second.
Member
There was a problem hiding this comment.
i thought the ticket said to keep total stats on every page
Author
There was a problem hiding this comment.
spoke with priya and it should just be on the first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #162
📝 Description
Made necessary backend adjustments to support frontend design:
Frontend:
✔️ Verification
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!