Sheffield | 26-Jan-ITP | Mona-Eltantawy | Sprint 3 | Coursework/sprint 3 implement and rewrite#1273
Conversation
…ge values using assert function
…ative and equal numbers.
…ed the code ensuring that all tests passed.
…undary and invalid cases.
…etCardValue function.
…character occurs in a string
…cases nd, th, st, and rd.
- Continue testing and implementing getOrdinalNumber for additional cases. - Write tests using Jest .
…e than 1, and to give empty out put for (0) and 'invalid count' output for negative counts.
…e code. - deleted the const greetingStr = greeting + ", " + name + "!"; because it is a redundant code that repeated already int the return function.
aslo removed the logPets function as it doesn't called.
Mona-Eltantawy
added
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 participant
Self checklist