Conversation
costowell
approved these changes
Feb 13, 2026
Contributor
costowell
left a comment
costowell
left a comment
There was a problem hiding this comment.
This PR showed me just how cursed local development still is. But it works! LGTM
Contributor
Author
|
idk what you mean local development isn't cursed (jk it's so so so bad) but i think we're getting there at least it's kinda documented... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #443 and generally fixes various bugs and race conditions when upgrading frosh accounts that would cause data to be lost
Why
All frosh in the history of conditional lost their hm attendance from the start of the semseter
Test Plan
Using a local copy of the db, upgrade a frosh account both without any conflicting hm attendance and with some hm attendance with their new uid and make sure it behaves correctnly
Env Vars
no, although there are db migrations
Checklist