Closed
Conversation
Plugin architecture:
- src/api/plugins.yaml: YAML registry voor alle recognizers en NER config
- src/api/utils/plugin_loader.py: laadt plugins.yaml, importeert PatternRecognizers by name
- src/api/utils/adapters/: stub voor toekomstige transformer/llm adapters
- src/api/services/text_analyzer.py: gebruikt plugin_loader ipv directe imports
Benchmarking:
- benchmarks/evaluate.py: custom IoU-based span evaluator (geen en_core_web_sm)
- benchmarks/data/dutch_pii_sentences.json: 24 gelabelde NL zinnen, alle 15 entity types
- benchmarks/thresholds.yaml: minimale precision/recall drempels per entiteitstype
- .github/workflows/benchmark.yml: CI quality gate op main/staging
Kubernetes + ArgoCD:
- k8s/base/: hardened deployment, service, ingress (NGINX + basic-auth + cert-manager)
- k8s/overlays/{dev,acc,prod}/: Kustomize overlays per omgeving
- argocd/applicationset.yaml: één ApplicationSet voor dev/acc/prod
- Ingress hostnames: api.{dev.,acc.}openanonymiser.commonground.nu
CI verbeteringen:
- docker-build.yml: test job vóór build; staging branch → acc tag
- CONTRIBUTING.md: agentic engineering sectie toegevoegd
- presidio-evaluator toegevoegd als dev dependency
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
readOnlyRootFilesystem=true in k8s deployment prevents creating 'logs/' at the working directory. /tmp is already mounted as emptyDir. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: