feat: Retention management — bewaartermijnen and selectielijsten#986
Merged
rubenvdlinde merged 3 commits intodevelopmentfrom Apr 9, 2026
Merged
feat: Retention management — bewaartermijnen and selectielijsten#986rubenvdlinde merged 3 commits intodevelopmentfrom
rubenvdlinde merged 3 commits intodevelopmentfrom
Conversation
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (586 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
5 tasks
rjzondervan
requested changes
Apr 8, 2026
Member
rjzondervan
left a comment
rjzondervan
left a comment
There was a problem hiding this comment.
PR shows various PHPstan errors, and is also using a way of calling server variables that is deprecated
Comment on lines
+171
to
+172
| $objectMapper = \OC::$server->get(MagicMapper::class); | ||
| $connection = \OC::$server->getDatabaseConnection(); |
Member
There was a problem hiding this comment.
This way of requesting global parameters is being phased out by Nextcloud and should not be added new
Comment on lines
+89
to
+94
| $retentionService = \OC::$server->get(RetentionService::class); | ||
| $settingsHandler = \OC::$server->get(ObjectRetentionHandler::class); | ||
| $objectMapper = \OC::$server->get(MagicMapper::class); | ||
| $auditMapper = \OC::$server->get(AuditTrailMapper::class); | ||
| $deleteObject = \OC::$server->get(DeleteObject::class); | ||
| $saveObject = \OC::$server->get(\OCA\OpenRegister\Service\Object\SaveObject::class); |
rubenvdlinde
added
ready-for-code-review
rjzondervan
approved these changes
Apr 9, 2026
Member
rjzondervan
left a comment
rjzondervan
left a comment
There was a problem hiding this comment.
Some style notes for later reference, furthermore ok.
Comment on lines
+141
to
+148
| MagicMapper $objectMapper, | ||
| LegalHoldService $legalHoldService, | ||
| DeleteObject $deleteObject, | ||
| AuditTrailMapper $auditTrailMapper, | ||
| IAppConfig $appConfig, | ||
| IJobList $jobList, | ||
| IUserSession $userSession, | ||
| LoggerInterface $logger |
Member
There was a problem hiding this comment.
Note for updating agents: these can all be done in the PHP 8 style:
private readonly MagicMapper $objectMapper,
And without needing any lines within the {} for the constructor.
| * | ||
| * @return array<string, mixed> The destruction certificate data. | ||
| */ | ||
| public function generateCertificate(array $destructionList, array $executionResult): array |
Comment on lines
+2954
to
+2963
| // Apply archival metadata from schema archive configuration. | ||
| try { | ||
| $retentionService = \OC::$server->get(\OCA\OpenRegister\Service\RetentionService::class); | ||
| $preparedObject = $retentionService->applyArchivalMetadata($preparedObject, $schema); | ||
| } catch (\Throwable $e) { | ||
| $this->logger->debug( | ||
| '[SaveObject] RetentionService not available, skipping archival metadata: '.$e->getMessage() | ||
| ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
When would the retentionservice not be available?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This PR was previously merged and reverted along with other PRs while investigating a development branch issue.