Open
Conversation
ar2rsawseen
force-pushed
the
ar2rsawseen/master2
branch
from
de3e3f1 to
c00ce63
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for Web User-Agent Client Hints for more reliable browser/OS/device detection in the web plugin, and validates the behavior with new integration tests.
Changes:
- Implement client-hints parsing + normalization and merge it with UA parsing (client hints take priority).
- Add integration tests covering UA parsing, client-hints priority, and normalization for browser/OS/device type.
- Send
Accept-CH/Critical-CHheaders in API responses to request client hints from browsers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| plugins/web/api/api.js | Adds client-hints parsing/normalization and uses it to populate session/crash metrics |
| plugins/web/tests.js | Adds integration tests for UA parsing + client-hints parsing/normalization |
| api/utils/common.js | Adds default response headers to request client hints (Accept-CH, Critical-CH) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.