Skip to content

Use distributionId instead of distributionType to identifiy disributions#215

Merged
oej merged 2 commits intoCycloneDX:mainfrom
taleodor:2026-02-distro-type-remove
Mar 3, 2026
Merged

Use distributionId instead of distributionType to identifiy disributions#215
oej merged 2 commits intoCycloneDX:mainfrom
taleodor:2026-02-distro-type-remove

Conversation

@taleodor
Copy link
Copy Markdown
Contributor

This PR resolves #198 for the 1.0 release. It removes the distributionType string field as it is not clearly enumerated. Instead it introduces the distributionId UUID field that allows to map TEA Artifacts to specific distributions.

…tributions [CycloneDX#198]

Signed-off-by: Pavel Shukhman <pavel@reliza.io>
@taleodor taleodor requested review from madpah and oej as code owners February 22, 2026 13:36
Copy link
Copy Markdown
Collaborator

@oej oej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oej
Copy link
Copy Markdown
Collaborator

oej commented Feb 25, 2026

Clarify scope of UUID - that it's global.

@taleodor
Copy link
Copy Markdown
Contributor Author

#217 - this should be apply to the TEA spec as a whole, not specifically to this PR.

Comment thread spec/openapi.yaml
Comment thread spec/openapi.yaml
"$ref": "#/components/schemas/checksum"
required:
- id
- distributionId
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a description be required too?

Suggested change
- distributionId
- distributionId
- description

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say no, this will become optional once we have proper ontology. I don't think we should make it required even at this stage.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Since all objects have UUIDs, human-readable names are not really necessary. Should we therefore also mark the name field of Product and Component as optional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here, but I'd say I wouldn't expect a Product or a Component to not have name. But maybe there are other opinions.

Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
Signed-off-by: Pavel Shukhman <taleodor@users.noreply.github.com>
@oej oej merged commit 1f8aefe into CycloneDX:main Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The distributionType field in release-distribution needs to be clarified

3 participants