Add output and labels to quickcmd#1534
Open
pajawojciech wants to merge 3 commits intoDFHack:masterfrom
Open
Conversation
chdoc
reviewed
Feb 10, 2026
Comment on lines
+37
to
+38
| local CONFIG_FILE_OLD = 'dfhack-config/quickcmd.json' | ||
| local CONFIG_FILE = 'dfhack-config/quickcmd-v2.json' |
Member
There was a problem hiding this comment.
@ab9rf Is there a policy for updating the configuration format for tools that are not world or site specific? I would tend to keep the configuration filename aligned with the name of the tool without adding any version suffixes, putting any versioning information about the configuration file format into the configuration file itself. That is, back up the old configuration file under a new name and then convert the configuration in place.
Member
There was a problem hiding this comment.
I'm inclined to agree with you here: keep the file name the same and store the version information into the file itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
quickcmd window:
Output window:
Old and new settings file:
Issues