feat: Migrating pilot client toward DiracX#8233
Draft
Robin-Van-de-Merghel wants to merge 3 commits intoDIRACGrid:integrationfrom
Draft
feat: Migrating pilot client toward DiracX#8233Robin-Van-de-Merghel wants to merge 3 commits intoDIRACGrid:integrationfrom
Robin-Van-de-Merghel wants to merge 3 commits intoDIRACGrid:integrationfrom
Conversation
Robin-Van-de-Merghel
changed the title
fstagni
changed the title
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
from
eaffc28 to
796281d
Compare
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
from
796281d to
eb1d1c7
Compare
fstagni
reviewed
Jul 1, 2025
src/DIRAC/WorkloadManagementSystem/scripts/dirac_admin_add_pilot.py
Outdated
Show resolved
Hide resolved
tests/Integration/WorkloadManagementSystem/Test_PilotsClient.py
Outdated
Show resolved
Hide resolved
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
from
ce29434 to
e413b2b
Compare
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
from
e413b2b to
898be85
Compare
Contributor
Author
|
Issue with So, if a user calls |
Contributor
I think it's fine. This functionality (storing the pilot output in a MySQL blob) is already borderline useful, and given that we are finally getting somewhere with the pilot logging in diracx, I am thinking it would be OK to remove it. If for the moment replying with an error is OK. |
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
from
a11a505 to
48e7ff6
Compare
18 tasks
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
6 times, most recently
from
8114684 to
2410060
Compare
Robin-Van-de-Merghel
force-pushed
the
robin-migrate-client
branch
2 times, most recently
from
d3a37ac to
5af196f
Compare
This was referenced Aug 7, 2025
fstagni
reviewed
Aug 7, 2025
| diracAdmin = DiracAdmin() | ||
| exitCode = 0 | ||
| errorList = [] | ||
| print("This command is not supported anymore with DIRAV V9.") |
Contributor
There was a problem hiding this comment.
Suggested change
| print("This command is not supported anymore with DIRAV V9.") | |
| print("This command is not supported anymore with DIRAC V9.") |
fstagni
reviewed
Aug 7, 2025
|
|
||
| @classmethod | ||
| def export_deletePilots(cls, pilotIDs): | ||
| # Used by no one. We keep it for tests. |
Contributor
There was a problem hiding this comment.
Nah, if it is not used just remove it.
fstagni
force-pushed
the
robin-migrate-client
branch
from
1110fb2 to
3a2745d
Compare
fstagni
reviewed
Mar 25, 2026
| - name: Building wheels | ||
| run: | | ||
| # Clone diracx | ||
| git clone --single-branch --branch robin-pilot-management https://github.com/Robin-Van-de-Merghel/diracx.git $GITHUB_WORKSPACE/diracx |
fstagni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*PilotManager
CHANGE: Migrate pilot client toward DiracX
ENDRELEASENOTES