fix: avoid duplicate network wait message in FUM flow#148
Open
WuXieSec wants to merge 1 commit intoDasharo:mainfrom
Open
fix: avoid duplicate network wait message in FUM flow#148WuXieSec wants to merge 1 commit intoDasharo:mainfrom
WuXieSec wants to merge 1 commit intoDasharo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an extra
wait_for_network_connection truecall inscripts/dasharo-deploy.shfor FUM startup.Why
board_config()already performs network readiness handling before downloading board configs. The extra pre-check in FUM path causes duplicate "Waiting for network connection..." messages in close succession.Change
scripts/dasharo-deploy.sh(around startup path)board_config()behavior unchanged (including offline fallback to local files)Result
Ref: Dasharo/dasharo-issues#1219