fix: append --filter to sync_cmd instead of diff_cmd in test_resource…#502
Merged
nathantournant merged 3 commits intomainfrom Apr 3, 2026
Merged
fix: append --filter to sync_cmd instead of diff_cmd in test_resource…#502nathantournant merged 3 commits intomainfrom
nathantournant merged 3 commits intomainfrom
Conversation
heyronhay
previously approved these changes
Mar 31, 2026
2 tasks
michael-richey
approved these changes
Apr 2, 2026
heyronhay
approved these changes
Apr 2, 2026
…_update_sync In test_resource_update_sync, the --filter argument was appended to diff_cmd instead of sync_cmd due to a copy-paste error. This caused the sync step to run unfiltered in live integration tests (RECORD=none), potentially syncing resources outside the test scope. Cassette-based tests masked the issue since VCR replays fixed responses regardless. Adds regression tests validating that command-building logic places filter arguments in the correct command lists. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When syncing roles cross-DC, permissions gated behind feature flags (e.g. bits_dev_write) may exist in the source org but not the destination. Previously, remap_permissions left the unresolved permission name as a raw string in the payload, causing the Roles API to reject it with "invalid UUID [permission_name]". Now, permissions that exist in the source but have no match in the destination are dropped from the role payload with a warning log. This prevents a single missing permission from breaking the entire role sync — and by extension every integration test teardown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Notebooks API now injects ai_generated, ai_edited, and human_edited tags on every write based on request characteristics. Since the sync CLI uses API key auth (not MCP), every PUT is classified as a human edit, causing human_edited:true to be added server-side. This creates a non-converging diff because the source notebook lacks the tag while the destination always gets it re-injected. Strip these server-managed tags in handle_special_case_attr so they are ignored on both sides during import, sync, and diff. Legitimate user tags (team:*, llm-observability:*) are unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nathantournant
force-pushed
the
fix/test-update-sync-filter-cmd
branch
from
cdfac01 to
d56fb9a
Compare
Member
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_update_sync
In test_resource_update_sync, the --filter argument was appended to diff_cmd instead of sync_cmd due to a copy-paste error. This caused the sync step to run unfiltered in live integration tests (RECORD=none), potentially syncing resources outside the test scope. Cassette-based tests masked the issue since VCR replays fixed responses regardless.
Adds regression tests validating that command-building logic places filter arguments in the correct command lists.
Requirements for Contributing to this repository
What does this PR do?
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.