Move build_agent.yaml PR creation from ddev CLI to a workflow_dispatch GitHub Action#22799
Draft
Kyle-Neale wants to merge 2 commits intomasterfrom
Draft
Move build_agent.yaml PR creation from ddev CLI to a workflow_dispatch GitHub Action#22799Kyle-Neale wants to merge 2 commits intomasterfrom
workflow_dispatch GitHub Action#22799Kyle-Neale wants to merge 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves ownership of the .gitlab/build_agent.yaml update from the ddev CLI to a GitHub Actions workflow.
Previously,
ddev release branch tagwould detect whenbuild_agent.yamlstill pointed tomain, attempt to update it in-place, commit, and push directly to the protected release branch.This PR replaces that approach with:
update-build-agent-yaml.ymlworkflow (workflow_dispatch) that checks out the release branch, verifies the agent branch exists indatadog-agent, updatesbuild_agent.yaml, and opens a bot PR targeting the release branch— consistent with how other automated PRs in this repo are created.build_agent.yamland aborts with an actionable message if it still points to main, including the exactghworkflow run command to trigger the update.Motivation
The CLI approach tried to push directly to a protected branch. The GitHub Actions approach uses a bot token (via actions/create-github-app-token) to open a PR, which is the established pattern in this repo (update-dependencies.yml,
update-agent-changelog.yml, etc.).
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged