Merged
Conversation
Contributor
|
Yes, I think it's a good idea to test writeSeparated. Please write some tests if possible! |
Contributor
|
@mchav - this looks good to go, right? |
Member
|
I was waiting on final word on the tests. We can proceed without them since it's a straightforward change. |
Contributor
|
i think maybe let's just go with it. seems low risk. i was just trying to peer pressure @Carrotstrip into writing some tests... |
Carrotstrip
force-pushed
the
writeTsv
branch
from
d13f6e4 to
b97900a
Compare
Carrotstrip
force-pushed
the
writeTsv
branch
from
b97900a to
fc2ba9e
Compare
Contributor
Author
|
removed the lazy function as discussed with @mchav. Re testing: since dataframe afaiu is sort of a port of a very canonical implementation of the concept of dataframes (pandas), would it make sense to use certain pandas outputs as a golden copy to compare our own outputs to? seems like it could be a useful class of testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just copied the implementation of writeCsv here, so I don't really understand why there are lazy and non-lazy versions. @mchav could you help me understand this?
Also, I didn't write any tests because there were none for writeCsv, but I did check out the output in the REPL. Would it be worth adding tests for both of these write functions, or maybe just the writeSeparated function that does most of the work? Maybe just a string comparison of manually audited output for some small dataframe?
#119