Skip to content

Conversation

@tieneupin
Copy link
Contributor

A recent FastAPI version update (around v0.128.3/4) broke the generate_route_manifest CLI. We previously extracted a URL endpoint path parameter's type information from the type_ attribute in the path parameter ModelField instance, which has been removed in said recent FastAPI version update. Further inspection indicates that it is a Pydantic v1 attribute, and has been phased out as part of deprecating Pydantic v1.

This PR replaces the use of the type_ attribute with the Pydantic v2 _type_adapter._type attribute, which contains the full type annotation of the path parameter. A helper function was introduced to extract the basic Python type from the annotation.

…f the 'type_' attribute of the path parameter ModelField instance; 'type_' is a Pydantic v1 attribute that has been removed
@tieneupin tieneupin requested review from d-j-hatton and stephen-riggs and removed request for stephen-riggs February 10, 2026 14:43
@tieneupin tieneupin self-assigned this Feb 10, 2026
@tieneupin tieneupin added bug Something isn't working enhancement New feature or request dependencies labels Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.64%. Comparing base (8fb34a2) to head (1039b57).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   46.65%   46.64%   -0.01%     
==========================================
  Files          91       91              
  Lines        9607     9615       +8     
  Branches     1255     1258       +3     
==========================================
+ Hits         4482     4485       +3     
- Misses       4912     4915       +3     
- Partials      213      215       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit 3375c27 into main Feb 11, 2026
18 of 19 checks passed
@tieneupin tieneupin deleted the route-manifest-cli-fix branch February 11, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants