Open
Conversation
Use a discriminated union for transfer request types so the buy and sell payloads stay distinct. For onramp (push payment), include only source.currency — no account ID or network — matching what the Infinite headless API expects.
j0ntz
force-pushed
the
jon/fix/infinite-push-transfer-source
branch
from
c19ef4f to
4a873a8
Compare
Move reset() from the catch block into finally so the SafeSlider returns to its idle state on both success and error paths. Previously a successful transfer with no deposit instructions left the slider spinning indefinitely.
j0ntz
force-pushed
the
jon/fix/infinite-push-transfer-source
branch
from
4a873a8 to
50009aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Asana task
Asana task
Context
Infinite buy confirmations were creating a push-payment onramp transfer with source details attached, which Infinite flagged as invalid for this flow.
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Touches fiat ramp transfer creation and confirmation UX; incorrect payloads or stricter validation could block buy flows or surface new runtime errors if Infinite responses differ from expectations.
Overview
Fixes Infinite buy/onramp transfer creation by splitting
createTransferinto explicitONRAMPvsOFFRAMPrequest payload types and removing onramp-only source fields that Infinite rejects.Tightens the Infinite confirmation workflow by dropping the now-unused
flowplumbing, validating that bank deposit instructions are present (otherwise throwing), and improvingRampConfirmationScenebehavior so the slider is always reset and errors are captured with correct typing. Adds a changelog entry for the fix.Written by Cursor Bugbot for commit 50009aa. This will update automatically on new commits. Configure here.