Open
Conversation
Introduce a non-deprecated flat navigation alias for shared code and update the transaction list scene to use it for legacy cross-navigator casts.
Clean up the existing contacts permission modal warnings so the feature work can build on a warning-free file.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Prevent contact permission prompts from appearing during passive thumbnail lookups and limit them to transaction-list or explicit payee edit flows.
j0ntz
force-pushed
the
jon/fix/remove-contacts-modal-first-receive
branch
from
b672ee4 to
8cda7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Remove contacts modal on first receive. The contacts permission prompt no longer appears from passive thumbnail lookup when a user receives funds. It now appears only when the user opens a transaction list with named transactions or explicitly edits the payee field from transaction details.