Skip to content

fix(bbr): correct argument order in bbr_get_raw_target_cwnd calls #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfb8856606 merged 1 commit into from
Mar 27, 2026
Merged

fix(bbr): correct argument order in bbr_get_raw_target_cwnd calls #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions freebsd/netinet/tcp_stacks/bbr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3466,7 +3466,7 @@ bbr_get_target_cwnd(struct tcp_bbr *bbr, uint64_t bw, uint32_t gain)

mss = min((bbr->rc_tp->t_maxseg - bbr->rc_last_options), bbr->r_ctl.rc_pace_max_segs);
/* Get the base cwnd with gain rounded to a mss */
cwnd = roundup(bbr_get_raw_target_cwnd(bbr, bw, gain), mss);
cwnd = roundup(bbr_get_raw_target_cwnd(bbr, gain, bw), mss);
/*
* Add in N (2 default since we do not have a
* fq layer to trap packets in) quanta's per the I-D
Expand Down Expand Up @@ -10718,8 +10718,8 @@ bbr_get_a_state_target(struct tcp_bbr *bbr, uint32_t gain)
mss = min((bbr->rc_tp->t_maxseg - bbr->rc_last_options),
bbr->r_ctl.rc_pace_max_segs);
/* Get the base cwnd with gain rounded to a mss */
tar = roundup(bbr_get_raw_target_cwnd(bbr, bbr_get_bw(bbr),
gain), mss);
tar = roundup(bbr_get_raw_target_cwnd(bbr, gain,
bbr_get_bw(bbr)), mss);
/* Make sure it is within our min */
if (tar < get_min_cwnd(bbr))
return (get_min_cwnd(bbr));
Expand Down
Loading