Skip to content

NEW: Remove cookies for completed download jobs#18

Open
PBXg33k wants to merge 1 commit intodevelopfrom
feature/clean-cookies-on-completed-jobs
Open

NEW: Remove cookies for completed download jobs#18
PBXg33k wants to merge 1 commit intodevelopfrom
feature/clean-cookies-on-completed-jobs

Conversation

@PBXg33k
Copy link
Copy Markdown
Contributor

@PBXg33k PBXg33k commented Apr 1, 2026

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

badge

Code Coverage Summary

Filename                                                         Stmts    Miss  Cover    Missing
-------------------------------------------------------------  -------  ------  -------  ----------------------------------------
Command/CoreDownloadersUpdateCommand.php                            19      19  0.00%    22-57
Command/DownloadRouterMigrationSetDownloadjobOwnerCommand.php       33      33  0.00%    32-93
Command/ScanDownloadedFilesCommand.php                              38      38  0.00%    30-98
Command/UrlDownloadCommand.php                                      36      36  0.00%    30-92
Controller/AuthController.php                                      236      12  94.92%   297-302, 356, 362-366
Controller/DownloadController.php                                   27      27  0.00%    18-78
Controller/WellKnownController.php                                  19       0  100.00%
DataFixtures/TestUserFixtures.php                                    4       0  100.00%
Doctrine/CurrentUserExtension.php                                   11      11  0.00%    20-40
Dto/CookieDTO.php                                                   27      17  37.04%   22-48
Dto/DownloadJobDTO.php                                               0       0  0.00%
Dto/JobAcceptedDTO.php                                              15       0  100.00%
Entity/DownloadJob.php                                              59       2  96.61%   153, 183
Entity/DownloadJobEvent.php                                         29      26  10.34%   66-74, 91-170
Entity/DownloadedFile.php                                           24      18  25.00%   67-71, 92-149
Entity/Downloader.php                                                0       0  0.00%
Entity/OidcSubjectIdentifier.php                                    14       0  100.00%
Entity/SupportedSite.php                                            16      16  0.00%    48-108
Entity/Version.php                                                   1       0  100.00%
Enum/DownloadStateEnum.php                                           7       7  0.00%    15-21
Enum/DownloaderTypeEnum.php                                          4       0  100.00%
Enum/JobTypeEnum.php                                                 3       0  100.00%
Event/CliProcessErrOutputEvent.php                                   1       1  0.00%    15
Event/CliProcessOutputEvent.php                                      2       2  0.00%    17-21
Event/CliProcessStartEvent.php                                       1       1  0.00%    15
Event/CliProcessStdOutputEvent.php                                   1       1  0.00%    15
Event/CliProcessStopEvent.php                                        1       1  0.00%    18
Event/JobCompletedEvent.php                                          4       0  100.00%
Event/JobFailedEvent.php                                             5       0  100.00%
Event/JobPickedUpEvent.php                                           4       0  100.00%
Event/JobUpdateEvent.php                                             5       0  100.00%
Event/ProcessStartEvent.php                                          1       1  0.00%    13
Event/ProcessStopEvent.php                                           1       1  0.00%    15
EventListener/CleanupListener.php                                    9       9  0.00%    17-32
EventListener/CliProcessListener.php                                29      29  0.00%    20-77
EventListener/JobEventLogger.php                                    59      59  0.00%    24-113
EventListener/ProcessStoppedListener.php                            44      44  0.00%    24-92
Factory/DownloaderFactory.php                                       16       0  100.00%
Handler/DownloadJobDTOHandler.php                                    1       1  0.00%    14
Handler/DownloadJobHandler.php                                      51       0  100.00%
Message/UpdateDownloadersMessage.php                                 0       0  0.00%
MessageHandler/UpdateDownloadersMessageHandler.php                  10      10  0.00%    19-32
Repository/DownloadJobEventRepository.php                            1       1  0.00%    16
Repository/DownloadJobRepository.php                                12      11  8.33%    21-35
Repository/DownloadedFileRepository.php                              1       0  100.00%
Repository/OidcSubjectIdentifierRepository.php                       1       0  100.00%
Repository/SupportedSiteRepository.php                               1       1  0.00%    16
Response/ErrorResponse.php                                           5       0  100.00%
Security/Core/User/OidcUser.php                                      6       1  83.33%   32
Security/Core/User/OidcUserProvider.php                             38       0  100.00%
Service/Downloader/AbstractCliDownloader.php                       105      65  38.10%   37-102, 111, 131, 143-149, 185, 191, 200
Service/Downloader/GalleryDlCliDownloader.php                       84      75  10.71%   45-173, 180, 190, 203-206
Service/Downloader/GalleryDlWebDownloader.php                      361     354  1.94%    23-406, 426-436
Service/Downloader/MockDownloader.php                                8       0  100.00%
Service/Downloader/YoutubeDlCliDownloader.php                       80      70  12.50%   49-107, 114, 124, 132-208, 218-221
State/DownloadJobQueuedProcessor.php                                54       1  98.15%   53
State/DownloaderProvider.php                                        24      24  0.00%    17-68
State/VersionProvider.php                                           34       0  100.00%
Validator/SelectDownloader.php                                       1       0  100.00%
Validator/SelectDownloaderValidator.php                              8       0  100.00%
TOTAL                                                             1691    1025  39.11%

Diff against develop

Filename                             Stmts    Miss  Cover
---------------------------------  -------  ------  --------
EventListener/CleanupListener.php       +9      +9  +100.00%
TOTAL                                   +9      +9  -0.21%

Results for commit: d18171a

Minimum allowed coverage is 35%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant