Skip to content

CI: Push Docker images for pull requests and main#1100

Closed
losolio wants to merge 1 commit intoFirelyTeam:r4/masterfrom
losolio:ci/docker-builds
Closed

CI: Push Docker images for pull requests and main#1100
losolio wants to merge 1 commit intoFirelyTeam:r4/masterfrom
losolio:ci/docker-builds

Conversation

@losolio
Copy link
Copy Markdown
Collaborator

@losolio losolio commented Feb 14, 2026

Enables automated Docker image publishing after successful integration tests, supporting multi-environment Kubernetes workflows:

  • Production: Pin to versioned releases (manual tagging)
  • Staging: Use :canary tag - automatically updated on every r4/master push

Copilot AI review requested due to automatic review settings February 14, 2026 20:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables automated Docker image publishing to DockerHub after successful integration tests, supporting a multi-environment deployment strategy. Images are tagged differently based on the trigger: :canary for pushes to r4/master (staging), and :edge-<sha> for pull requests (development/preview environments). External fork PRs are excluded from publishing for security.

Changes:

  • Migrated from simple docker build commands to GitHub Actions' build-push-action with multi-architecture support (amd64, arm64)
  • Added automated Docker image pushing after successful tests with environment-specific tagging
  • Implemented PR commenting to inform developers of the published image tags for testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/integration_tests.yml Outdated
Comment thread .github/workflows/integration_tests.yml
Comment thread .github/workflows/integration_tests.yml
Comment thread .github/workflows/integration_tests.yml
Comment thread .github/workflows/integration_tests.yml Outdated
Copy link
Copy Markdown
Collaborator

@kennethmyhra kennethmyhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the canary build, we can drop the edge build for now

Comment thread .github/workflows/integration_tests.yml Outdated
Comment on lines +10 to +11
env:
DOCKERHUB_ORG: sparkfhir
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can swap this one out with the one from our secrets secrets.DOCKERHUB_ORGANIZATION. See

${{ secrets.DOCKERHUB_ORGANIZATION }}/spark:${{ steps.vars.outputs.tag }}
${{ secrets.DOCKERHUB_ORGANIZATION }}/spark:r4-latest
${{ secrets.DOCKERHUB_ORGANIZATION_2 }}/spark:${{ steps.vars.outputs.tag }}
${{ secrets.DOCKERHUB_ORGANIZATION_2 }}/spark:r4-latest

Comment thread .github/workflows/integration_tests.yml Outdated
@losolio losolio force-pushed the ci/docker-builds branch 7 times, most recently from 379d1b7 to 5099222 Compare March 15, 2026 19:20
Enables automated Docker image publishing with
canary tags after pushes to r4/master.
@losolio
Copy link
Copy Markdown
Collaborator Author

losolio commented Apr 14, 2026

Closing this for now. Should be rethought later.

@losolio losolio closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants