Skip to content

Skip ReadKind_IsSymlink test on Windows when lacking I/O privileges #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ForNeVeR merged 8 commits into from
Feb 10, 2026
Merged

Skip ReadKind_IsSymlink test on Windows when lacking I/O privileges #205

ForNeVeR merged 8 commits into from
Feb 10, 2026
+25 −11

Conversation

@pkazakov-dev
Copy link
Contributor

@pkazakov-dev pkazakov-dev commented Feb 9, 2026 •
edited
Loading

Contains:

  • Update to xunit.v3 + FsCheck.xunit.v3 (no changes, only package updates)
  • Update ReadKind_IsSymlink test with runtime check for I/O privileges (test requires elevated privileges on Windows due to OS-level restrictions)
  • Update docs reflecting elevated privileges requirement for symlink test on Windows

pkazakov-dev
pkazakov-dev commented Feb 9, 2026
View reviewed changes
ForNeVeR
ForNeVeR approved these changes Feb 9, 2026
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR
Copy link
Owner

ForNeVeR commented Feb 9, 2026

Oh, the CI feels very unwell, could you please take a look?

@pkazakov-dev
Copy link
Contributor Author

pkazakov-dev commented Feb 10, 2026

Oh, the CI feels very unwell, could you please take a look?

Fixed =)

@pkazakov-dev pkazakov-dev changed the title Update to use xunit.v3 Skip ReadKind_IsSymlink test on Windows when lacking I/O privileges Feb 10, 2026
ForNeVeR
ForNeVeR approved these changes Feb 10, 2026
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit e4dc94a into ForNeVeR:main Feb 10, 2026
10 checks passed
@pkazakov-dev pkazakov-dev deleted the feat/update_to_xunit_v3 branch February 10, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@pkazakov-dev pkazakov-dev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pkazakov-dev @ForNeVeR