chore: bump otelcontribcol to v0.133.0-gke.3#2084
chore: bump otelcontribcol to v0.133.0-gke.3#2084google-oss-prow[bot] merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
Camila-B
commented
Mar 7, 2026
- Needed to fix CVEs
- Release notes https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.133.0
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version of the OpenTelemetry Collector Contrib (otelcontribcol) to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the otelcontribcol version to v0.133.0-gke.3. This is a significant version jump which may introduce breaking changes. My review identifies potential issues with an outdated feature gate and hardcoded metric names that could be affected by this upgrade. Addressing these points will help ensure that the observability pipeline continues to function correctly.
| GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION) | ||
|
|
||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.7 | ||
| OTELCONTRIBCOL_VERSION := v0.133.0-gke.3 |
There was a problem hiding this comment.
This version bump is a significant jump and may introduce breaking changes. I've identified two potential areas of concern:
-
otel-collectorfeature gate: Theotel-collectordeployment inmanifests/templates/otel-collector.yamluses the feature gate--feature-gates=-pkg.translator.prometheus.NormalizeName. The comment for this gate refers tov0.86.0. This feature gate may no longer be valid inv0.133.0. If it has been removed or promoted, theotel-collectorpod could fail to start. The command-line argument should be updated or removed to prevent deployment failures. -
Metric name filtering: The configuration in
pkg/metrics/otel_collector_config.goincludes afilter/cloudmonitoringprocessor with a hardcoded list of metric names. Metric names may have changed in the new version, which would cause them to be silently dropped from monitoring. The list of metric names in the filter should be cross-referenced with the new version's metrics.
|
Suggest checking for breaking changes since 0.127.0, and adjust Config Sync otel-agent config or otel-collector config as needed, the otel-agent seems to having trouble to start from the test. |
* Removed `--feature-gates=-pkg.translator.prometheus.NormalizeName` because feature gate "pkg.translator.prometheus.NormalizeName" is stable and cannot be disabled as of v0.129.0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
55f8c15
into
GoogleContainerTools:main
* chore: bump otelcontribcol to v0.133.0-gke.3 * Remove stable otel feature gate * Removed `--feature-gates=-pkg.translator.prometheus.NormalizeName` because feature gate "pkg.translator.prometheus.NormalizeName" is stable and cannot be disabled as of v0.129.0
* chore: bump otelcontribcol to v0.133.0-gke.3 * Remove stable otel feature gate * Removed `--feature-gates=-pkg.translator.prometheus.NormalizeName` because feature gate "pkg.translator.prometheus.NormalizeName" is stable and cannot be disabled as of v0.129.0