Skip to content

chore: bump otelcontribcol to v0.133.0-gke.3#2084

Merged
google-oss-prow[bot] merged 2 commits intoGoogleContainerTools:mainfrom
Camila-B:bump-otel
Mar 10, 2026
Merged

chore: bump otelcontribcol to v0.133.0-gke.3#2084
google-oss-prow[bot] merged 2 commits intoGoogleContainerTools:mainfrom
Camila-B:bump-otel

Conversation

@Camila-B
Copy link
Contributor

@Camila-B Camila-B commented Mar 7, 2026

@Camila-B Camila-B requested a review from tiffanny29631 March 7, 2026 00:54
@google-oss-prow google-oss-prow bot requested review from cowsking and janetkuo March 7, 2026 00:54
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the version of the OpenTelemetry Collector Contrib (otelcontribcol) to v0.133.0-gke.3. This essential update primarily aims to resolve critical security vulnerabilities by incorporating the latest fixes and improvements from the upstream project, ensuring the system remains secure and up-to-date.

Highlights

  • OpenTelemetry Collector Contrib Version Bump: Updated the OTELCONTRIBCOL_VERSION in the Makefile from v0.127.0-gke.7 to v0.133.0-gke.3.
  • CVE Fixes: The version bump was necessary to address and fix identified Common Vulnerabilities and Exposures (CVEs) as noted in the pull request description.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Makefile
    • Updated the OTELCONTRIBCOL_VERSION variable to v0.133.0-gke.3.
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the otelcontribcol version to v0.133.0-gke.3. This is a significant version jump which may introduce breaking changes. My review identifies potential issues with an outdated feature gate and hardcoded metric names that could be affected by this upgrade. Addressing these points will help ensure that the observability pipeline continues to function correctly.

GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION)

OTELCONTRIBCOL_VERSION := v0.127.0-gke.7
OTELCONTRIBCOL_VERSION := v0.133.0-gke.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This version bump is a significant jump and may introduce breaking changes. I've identified two potential areas of concern:

  1. otel-collector feature gate: The otel-collector deployment in manifests/templates/otel-collector.yaml uses the feature gate --feature-gates=-pkg.translator.prometheus.NormalizeName. The comment for this gate refers to v0.86.0. This feature gate may no longer be valid in v0.133.0. If it has been removed or promoted, the otel-collector pod could fail to start. The command-line argument should be updated or removed to prevent deployment failures.

  2. Metric name filtering: The configuration in pkg/metrics/otel_collector_config.go includes a filter/cloudmonitoring processor with a hardcoded list of metric names. Metric names may have changed in the new version, which would cause them to be silently dropped from monitoring. The list of metric names in the filter should be cross-referenced with the new version's metrics.

@tiffanny29631
Copy link
Contributor

Suggest checking for breaking changes since 0.127.0, and adjust Config Sync otel-agent config or otel-collector config as needed, the otel-agent seems to having trouble to start from the test.

Camila-B added 2 commits March 9, 2026 21:34
* Removed `--feature-gates=-pkg.translator.prometheus.NormalizeName` because feature gate "pkg.translator.prometheus.NormalizeName" is stable and cannot be disabled as of v0.129.0
Copy link
Contributor

@tiffanny29631 tiffanny29631 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiffanny29631

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 55f8c15 into GoogleContainerTools:main Mar 10, 2026
7 checks passed
Camila-B added a commit to Camila-B/kpt-config-sync that referenced this pull request Mar 10, 2026
* chore: bump otelcontribcol to v0.133.0-gke.3

* Remove stable otel feature gate

* Removed `--feature-gates=-pkg.translator.prometheus.NormalizeName` because feature gate "pkg.translator.prometheus.NormalizeName" is stable and cannot be disabled as of v0.129.0
Camila-B added a commit that referenced this pull request Mar 11, 2026
* chore: bump otelcontribcol to v0.133.0-gke.3

* Remove stable otel feature gate

* Removed `--feature-gates=-pkg.translator.prometheus.NormalizeName` because feature gate "pkg.translator.prometheus.NormalizeName" is stable and cannot be disabled as of v0.129.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants