chore: bump Go and Helm#2089
Conversation
Camila-B
commented
Mar 9, 2026
Camila-B
commented
- Bumps GOLANG_IMAGE_VERSION from 1.25.7 to 1.25.8
- Bumps Helm version from v3.18.6-gke.3 to v3.20.0-gke.1
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine dependency maintenance by updating the Go and Helm versions utilized in the project's build and deployment processes. These updates ensure the project benefits from the latest stable releases, incorporating any bug fixes, security enhancements, or new features provided by these essential tools. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the versions for the Go image and Helm. The changes are straightforward. I've suggested adding automation scripts for updating these versions in the future, to align with how other dependencies in the project are managed. This would improve maintainability and consistency.
| # Base image used for all golang containers | ||
| # Uses trusted google-built golang image | ||
| GOLANG_IMAGE_VERSION := 1.25.7 | ||
| GOLANG_IMAGE_VERSION := 1.25.8 |
There was a problem hiding this comment.
This version is being updated manually. For consistency with other dependencies in this Makefile (like DEBIAN_BASE_IMAGE on line 47 and GIT_SYNC_VERSION on line 94), consider adding a script to automatically find and update the GOLANG_IMAGE_VERSION. This would improve maintainability and reduce manual effort for future updates.
| KUSTOMIZE_STAGING_DIR := $(OUTPUT_DIR)/third_party/kustomize | ||
|
|
||
| HELM_VERSION := v3.18.6-gke.3 | ||
| HELM_VERSION := v3.20.0-gke.1 |
There was a problem hiding this comment.
Similar to the Go image version, consider adding a script to automate updating the HELM_VERSION. This would align with the approach used for other dependencies like DEBIAN_BASE_IMAGE and GIT_SYNC_VERSION, making the update process more consistent and less manual.
| KUSTOMIZE_STAGING_DIR := $(OUTPUT_DIR)/third_party/kustomize | ||
|
|
||
| HELM_VERSION := v3.18.6-gke.3 | ||
| HELM_VERSION := v3.20.0-gke.1 |
There was a problem hiding this comment.
Update version in tool_util.go
* Bumps GOLANG_IMAGE_VERSION from 1.25.7 to 1.25.8 * Bumps Helm version from v3.18.6-gke.3 to v3.20.0-gke.1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 27502e1
into
GoogleContainerTools:main
* Bumps GOLANG_IMAGE_VERSION from 1.25.7 to 1.25.8 * Bumps Helm version from v3.18.6-gke.3 to v3.20.0-gke.1
2 participants
