Fully qualify base types in macros#1310
Merged
Simn merged 6 commits intoHaxeFoundation:masterfrom Feb 20, 2026
Merged
Conversation
Using \r instead of a literal carriage return character prevents editors from trying to normalise the newlines.
:: causes issues if it comes in between the return type of a function and the function name, so we have to dodge those cases
Member
|
I've noticed this inconsistency before and wanted to bring it up. Thanks for looking into that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing
::to qualify the types as global inside macros causes issues if they are expanded in a context where there is a name collision, e.g. the user has::sub::hx::or::sub::String.I've also added a regex check to ci to match against these to prevent more getting introduced.
Closes HaxeFoundation/haxe#11831
See also #899, #1181, HaxeFoundation/haxe#8543