Skip to content

Fix rust build cache github actions#213

Merged
ChristianPavilonis merged 3 commits intomainfrom
fix/github-actions-build-cache
Feb 12, 2026
Merged

Fix rust build cache github actions#213
ChristianPavilonis merged 3 commits intomainfrom
fix/github-actions-build-cache

Conversation

@ChristianPavilonis
Copy link
Copy Markdown
Collaborator

@ChristianPavilonis ChristianPavilonis commented Jan 29, 2026

First run: Rust tests ~5min run
Second run: Rust tests ~1min run

@ChristianPavilonis ChristianPavilonis force-pushed the fix/github-actions-build-cache branch from e4c644a to a7f7d4a Compare January 29, 2026 14:48
@ChristianPavilonis ChristianPavilonis changed the title DRAFT: fix rust build cache github actions Fix rust build cache github actions Jan 29, 2026
@ChristianPavilonis ChristianPavilonis marked this pull request as ready for review January 29, 2026 14:49
@ChristianPavilonis ChristianPavilonis force-pushed the fix/github-actions-build-cache branch from a7f7d4a to f244195 Compare January 29, 2026 14:50
Copy link
Copy Markdown
Collaborator

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good overall but need to retain pinned Rust version

Comment thread .github/workflows/format.yml
@ChristianPavilonis ChristianPavilonis force-pushed the fix/github-actions-build-cache branch from 5075497 to 12380f6 Compare February 4, 2026 21:52
Copy link
Copy Markdown
Collaborator

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we need rustup for wasm

Comment thread .github/workflows/format.yml
The PR removed the manual 'rustup target add wasm32-wasip1' step but
didn't replace it, causing CI to fail with missing wasm target errors.
Use the action's built-in 'target' parameter instead.
Copy link
Copy Markdown
Collaborator

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@ChristianPavilonis ChristianPavilonis merged commit 1812476 into main Feb 12, 2026
10 checks passed
@aram356 aram356 deleted the fix/github-actions-build-cache branch February 12, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants