UID2-2885 Optout UI Improvement by swibi-ttd · Pull Request #600 · IABTechLab/uid2-admin

swibi-ttd · 2026-02-13T00:00:48Z

API Changes:

GET /api/partner_config/list - List all partner configs
GET /api/partner_config/get/{partner_name} - Get specific partner config
POST /api/partner_config/add - Add new partner
PUT /api/partner_config/update - Update existing partner
DELETE /api/partner_config/delete - Delete partner
POST /api/partner_config/bulk_replace - Replace all configs (renamed from update and moved to Danger Zone)

UI Changes:

Updated operations in OptOut Partner Management page to reflect API changes

sophia-chen-ttd · 2026-02-13T03:17:08Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+    private void handlePartnerConfigGet(RoutingContext rc) {
+        try {
+            final String partnerName = rc.pathParam("partner_name");
+            if (partnerName == null) {


Maybe also check if this is an empty string

Added check for empty string

sophia-chen-ttd · 2026-02-13T03:44:41Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+            }
+
+            String config = this.partnerConfigProvider.getConfig();
+            JsonArray allPartnerConfigs = new JsonArray(config);


Can we put these into one line like you do for the other methods

sophia-chen-ttd · 2026-02-13T03:45:23Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+            JsonArray allPartnerConfigs = new JsonArray(config);
+
+            // Look for the specific partner
+            for (int i = 0; i < allPartnerConfigs.size(); i++) {


You reuse a similar logic in most of these methods, can we look at putting this into a reusable function

Added findPartnerIndex helper fn

sophia-chen-ttd · 2026-02-13T03:45:58Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+
+    private void handlePartnerConfigAdd(RoutingContext rc) {
+        try {
+


Nit: Remove this space

sophia-chen-ttd · 2026-02-13T03:47:25Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+
+            rc.response()
+                    .putHeader(HttpHeaders.CONTENT_TYPE, "application/json")
+                    .end("\"success\"");


Can we respond with the new partner config that we added

Changed to respond with new config

sophia-chen-ttd · 2026-02-13T03:48:12Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+
+            rc.response()
+                    .putHeader(HttpHeaders.CONTENT_TYPE, "application/json")
+                    .end("\"success\"");


Can we respond with the new updated object

Changed to respond with updated object

sophia-chen-ttd · 2026-02-13T03:52:54Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+                ResponseUtil.error(rc, 400, "Partner name is required");
+                return;
+            }
+            final String partnerName = partnerNames.getFirst();


Why do we accept a list of partnerNames but only remove the first partner?

I think RoutingContext.queryParam is a list of Strings since you can always specify multiple values for each query param eg. /delete/?partner_name=partner1&partner_name=partner2 despite only expecting one partner_name here. src/main/java/com/uid2/admin/vertx/service/SiteService.java has the same behaviour in handleSiteAdd

Got it, thanks

sophia-chen-ttd · 2026-02-13T03:54:07Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+    private void handlePartnerConfigBulkReplace(RoutingContext rc) {
        try {
            // refresh manually
            this.partnerConfigProvider.loadContent();


Can we refresh the provider manually for all methods before retrieving the config?

Added manual refresh in all methods

sophia-chen-ttd · 2026-02-13T03:56:43Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+        try {
+
+            JsonObject newConfig = rc.body().asJsonObject();
+            if (newConfig == null) {


Should we put this check in the validatePartnerConfig method as well?

Yep added null check to validatePartnerConfig. I've left the existing checks in so we can give better errors

sophia-chen-ttd · 2026-02-13T05:45:21Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+            storageManager.upload(allPartnerConfigs);
+            rc.response()
+                    .putHeader(HttpHeaders.CONTENT_TYPE, "application/json")
+                    .end("\"success\"");


Can we also return the deleted object here? We can return a new object similar to what we do for ClientSideKeyPairs like:
{
success: true,
deleted_partner: allPartnerConfigs.get(existingPartnerIdx)
}

Updated to return deleted object. Do you think it's sufficient to return 200 + deleted object or would you still prefer to add success: true as well?

Yes that's fine, returning the deleted object was the main thing I wanted!

sophia-chen-ttd · 2026-02-13T05:49:13Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+
            storageManager.upload(partners);

            rc.response()


Can we also return the replaced partner config here

Now returns replace config

sophia-chen-ttd · 2026-02-13T05:57:45Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

            }
-        }, new AuditParams(Collections.emptyList(), List.of("partner_id", "config")), Role.PRIVILEGED));
+        }, new AuditParams(Collections.emptyList(), List.of("name")), Role.MAINTAINER));
+        router.delete(API_PARTNER_CONFIG_DELETE.toString()).blockingHandler(auth.handle((ctx) -> {


Lets also put the DELETE operation in the danger zone as a PRIVILEGED role

Moved to danger zone and updated to Role.PRIVILEGED

sophia-chen-ttd · 2026-02-13T06:00:59Z

src/main/java/com/uid2/admin/vertx/service/PartnerConfigService.java

+                this.handlePartnerConfigDelete(ctx);
+            }
+        }, new AuditParams(List.of("partner_name"), Collections.emptyList()), Role.MAINTAINER));
+        router.post(API_PARTNER_CONFIG_BULK_REPLACE.toString()).blockingHandler(auth.handle((ctx) -> {


Let's make bulk replace for Role.SUPERUSER

Updated to Role.SUPERUSER

swibi-ttd added 16 commits February 11, 2026 10:23

rename /api/partner_config/get to /api/partner_config/list

650f514

implement /api/partner_config/:partner_name

06add62

use JsonArray

e524a95

ignore case when comparing Partner names

a104182

change endpoint path to /get/:partner_name

628a4f3

implement /api/partner_config/add

84268a9

implement update

2ee8d0a

implement delete

7e9d557

reinstate bulk replace functionality at /bulk_replace

f89f61a

add validation added/updated configs

6ce4c29

add unit tests

ea38ac6

update response code

ba04922

update operations on Partner Management page

eca0b05

allow bulk update to include an empty array

28ccf16

simplify unit tests

e715a00

remove unused imports

8a9e517

sophia-chen-ttd reviewed Feb 13, 2026

View reviewed changes

check that no duplicate partner names are added during bulk replace

83bc46c

sophia-chen-ttd reviewed Feb 13, 2026

View reviewed changes

swibi-ttd added 4 commits February 13, 2026 15:47

check for empty partner name

5e7d0f2

add findPartnerIndex helper function

7786c5d

manual refresh in every handler

d6bc7cf

return with updated config instead of just success

673f0ec

swibi-ttd and others added 2 commits February 13, 2026 16:08

add null check to validatePartnerConfig

4e99a1f

[CI Pipeline] Released Snapshot version: 6.12.12-alpha-221-SNAPSHOT

2c85e2d

sophia-chen-ttd reviewed Feb 13, 2026

View reviewed changes

swibi-ttd added 4 commits February 13, 2026 17:07

return deleted config

5cb9e97

return bulk replaced config

6d6f6f1

update roles and move /delete to danger zoen

bd0f3f6

update tests for auth changes

bac9f94


		private void handlePartnerConfigAdd(RoutingContext rc) {
		try {

Conversation

swibi-ttd commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swibi-ttd Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

swibi-ttd commented Feb 13, 2026 •

edited

Loading

swibi-ttd Feb 13, 2026 •

edited

Loading