Open
Conversation
feat: Add configurable health probes and improve deployment template - Add support for configurable startup, liveness, and readiness probes - Support HTTP, TCP, and exec probe types with full parameter control - Fix authentication issues with web-enabled smtp4dev by allowing TCP probes - Add conditional environment variable rendering to avoid empty values - Make container ports configurable through values - Add support for additional volumes and volume mounts - Improve overall template flexibility and maintainability BREAKING CHANGE: Health probes are now configurable through values.yaml. Default behavior changes from HTTP to TCP probes on SMTP port 25. Fixes: Container crashes when web authentication is enabled
|
Hello, at work we have a deployment with this image that is running in an AWS cluster, which seems to block communications on port 25 altogether (even internally, between our app's test pod and the smtp4dev pod). So we could really use the change in this PR that allows the SMTP server to run on a port other than 25. Is there perhaps an ETA for a release that includes this change? If there is any way I could help, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add configurable health probes and improve deployment template
BREAKING CHANGE: Health probes are now configurable through values.yaml. Default behavior changes from HTTP to TCP probes on SMTP port 25.
Fixes: Container crashes when web authentication is enabled
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]