Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical mathematical bug in
csa/geometry.pywhere thegrid3dfunction uses true division instead of floor division for spatial indexing.Closes #37
The Fix
I have updated the$y$ and $z$ coordinate calculations. This ensures that 1D indices are correctly mapped to discrete 3D grid points without floating-point "drift" or "leakage".
grid3dlambda function to use the floor division operator (//) for theSafety and Necessity
grid3dinto alignment with the existing (and correct) implementation ofgrid2d.grid3dto ensure they match the expected discrete bins. It does not change the function's signature or return types.Verification
Verification was performed by calculating the Taxicab distance between the origin and high-index grid points (e.g., index 111 in a width-10 grid). Before the fix, coordinates leaked into floating-point decimals; after the fix, coordinates correctly aligned to the grid centers (0.1, 0.1, 0.1).