Skip to content

feat: add rmsnorm op on cambricon impl#19

Open
bitzyz wants to merge 3 commits intofeat/dev-infrafrom
feat/dev-rmsnorm-cambricon
Open

feat: add rmsnorm op on cambricon impl#19
bitzyz wants to merge 3 commits intofeat/dev-infrafrom
feat/dev-rmsnorm-cambricon

Conversation

@bitzyz
Copy link

@bitzyz bitzyz commented Mar 12, 2026 •
edited
Loading

  1. ✅Modified data_type.h to support low precision WITH_CAMBRICON
  2. ✅ Added rmsnorm cambricon op in src/cambricon/rms_norm
  3. ✅ Modified CMakeLists.txt to correctly handle .mlu files (using cncc compiler)
  4. ✅ Added definition for NRAM_MAX_SIZE
  5. ✅ Added definition for sumInternal function
  6. ✅ Used BANG macro for conditional compilation of MLU-specific code
  7. ✅ Fixed member initialization order in base/rms_norm.h

@bitzyz bitzyz self-assigned this Mar 12, 2026
@bitzyz bitzyz force-pushed the feat/dev-rmsnorm-cambricon branch 3 times, most recently from 7655800 to 35e2a2a Compare March 13, 2026 03:35
@bitzyz
Copy link
Author

bitzyz commented Mar 13, 2026

image

@bitzyz bitzyz force-pushed the feat/dev-rmsnorm-cambricon branch from 482aa74 to 0a49972 Compare March 16, 2026 06:36
@bitzyz bitzyz requested a review from voltjia March 16, 2026 06:38
@bitzyz bitzyz changed the title feat: add op on cambricon impl feat: add rmsnorm op on cambricon impl Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@voltjia voltjia Awaiting requested review from voltjia

Assignees

@bitzyz bitzyz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bitzyz