Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves SQL extraction from tagged template literals so escaped characters (notably backticks) are interpreted correctly, and adds demo coverage for quoted identifiers in PostgreSQL and MySQL.
Changes:
- Switch SQL extraction in the SWC tag parser to prefer the template literal’s “cooked” value, falling back to “raw” when needed.
- Add PostgreSQL demo queries covering double-quoted identifiers (table, qualified table, and columns).
- Add MySQL demo queries covering backtick-escaped identifiers (table, qualified table, and columns) along with snapshots.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/demo/select/double_quote_escaping.ts | Adds demo queries for PostgreSQL double-quoted identifiers. |
| tests/demo/select/double_quote_escaping.snapshot.ts | Adds snapshot typings for the new PostgreSQL demo queries. |
| tests/demo/select/double_quote_escaping.queries.ts | Adds expected generated typings for the new PostgreSQL demo queries. |
| tests/demo/mysql/backtick_escaping.ts | Adds demo queries for MySQL backtick-escaped identifiers (requires cooked template parsing). |
| tests/demo/mysql/backtick_escaping.snapshot.ts | Adds snapshot typings for the new MySQL demo queries. |
| tests/demo/mysql/backtick_escaping.queries.ts | Adds expected generated typings for the new MySQL demo queries. |
| src/parser/tag.rs | Fixes template literal handling by using cooked strings (with raw fallback) for SQL text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.