Add support for multi-threaded xpath evaluation#191
Open
maartendeprez wants to merge 1 commit intoKWARC:masterfrom
Open
Add support for multi-threaded xpath evaluation#191maartendeprez wants to merge 1 commit intoKWARC:masterfrom
maartendeprez wants to merge 1 commit intoKWARC:masterfrom
Conversation
Member
|
Thank you, this appears to be a very useful extension. Could I also request that you mirror our one findnodes test here: rust-libxml/tests/xpath_tests.rs Lines 122 to 144 in 4224fd9 With a similar entry inside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
readonlymodule provides support for multi-threaded read-only operations over a parsed document. However, thefindnodesmethod takes a shared reference to aDocument, which is not readonly and therefore notSend+Sync. This makes it impossible, currently, to evaluate xpaths over the document from multiple threads.This PR changes that by introducing a read-only version of
Document,ContextandObject, as well as afindnodes_readonlymethod onRoNode.