add first prototype of texElementImage2D#3752
add first prototype of texElementImage2D#3752cabanier wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
One initial comment. Likely this PR will remain unmerged for a while until there are prototype implementations of this new API. In the meantime, progress can be made on the API's semantics, addressing the TBD mentioned here, etc.
specs/latest/2.0/index.html
Outdated
| <p>The width and height of the texture are derived from the CSS width and height of the element at the time of rendering. Add links to whatwg.</p> | ||
| <p>TBD: define state of rendering + security. These will be more links to whatwg</p><p></p> | ||
| <p>If no WebGLBuffer is bound to the <code>PIXEL_PACK_BUFFER</code> target, generates an | ||
| <code>INVALID_OPERATION</code> error.</p> |
There was a problem hiding this comment.
This validation related to PIXEL_PACK_BUFFER looks reversed; if a buffer's bound to that target then the textures' contents come from it. I think that instead this should say "If a WebGLBuffer is bound...", since the goal is for the texture's contents to come from the rendered element.
|
The answer to WICG/html-in-canvas#68 in this PR seems to be that we do keep |
|
@cabanier what's still needed to make this ready for review? whatwg/html#11588 is making steady progress and I want to make sure the WebGL side is in sync. Importantly, the HTML spec now has a concept of an "element image snapshot" which is what must be used in canvas APIs like this one. Can you update the spec text to use that concept? You can use a direct link to https://whatpr.org/html/11588/canvas.html#concept-canvas-element-image-snapshots until the HTML spec PR is merged. |
3 participants
cc @kenrussell