refactor(kiloclaw): replace react-rewards with canvas-confetti#1387
Draft
refactor(kiloclaw): replace react-rewards with canvas-confetti#1387
Conversation
…mpletion animation Extract CompletionStep into its own component and replace the react-rewards emoji confetti with canvas-confetti side cannons animation. Add the Magic UI confetti component via shadcn registry for future reuse. - Remove react-rewards dependency - Add canvas-confetti + @types/canvas-confetti - Add @magicui/confetti component to src/components/magicui/ - Extract inline completion UI from ClawDashboard into CompletionStep - Add CompletionStep storybook story
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-rewardswithcanvas-confettifor the KiloClaw completion step animationClawDashboard.tsxinto a dedicatedCompletionStepcomponentsrc/components/magicui/confetti.tsx) via the shadcn registry for future reuse@magicuiregistry incomponents.jsonreact-rewardsdependency (only consumer was CompletionStep)canvas-confetti+@types/canvas-confettias replacements@types/pg@^8.18.0to prevent duplicate drizzle-orm resolutionsCompletionStepcomponentVerification
pnpm typecheck-- passes (fixed duplicate drizzle-orm resolution via@types/pgoverride)oxfmt --list-different .-- passesoxlint+eslint-- passesVisual Changes
Reviewer Notes
The confetti animation style changed from emoji-based (crab emojis from center) to a side-cannons effect (colorful confetti from bottom corners for 3 seconds). The
@magicui/confetticomponent was installed butCompletionStepusescanvas-confettidirectly since the side-cannons pattern doesn't need the wrapper component -- the component is available for other future uses.Adding
canvas-confetticaused@opentelemetry/instrumentation-pgto pull in@types/pg@8.15.6alongside the existing@types/pg@8.18.0, which created a second drizzle-orm instance with incompatible private types. The pnpm override for@types/pg@^8.18.0forces a single resolution.