Merged
Conversation
Thibault-Pelletier
changed the base branch from
main
to
slicer-wheel-support
AlexyPellegrini
force-pushed
the
slicer-core-sdk-based
branch
from
ec64ae6 to
1259140
Compare
AlexyPellegrini
force-pushed
the
slicer-core-sdk-based
branch
from
1259140 to
716181f
Compare
AlexyPellegrini
force-pushed
the
slicer-core-sdk-based
branch
2 times, most recently
from
a10031c to
85e8618
Compare
Collaborator
Author
|
@Thibault-Pelletier ready |
AlexyPellegrini
force-pushed
the
slicer-core-sdk-based
branch
3 times, most recently
from
4cdffec to
6856316
Compare
AlexyPellegrini
force-pushed
the
slicer-core-sdk-based
branch
2 times, most recently
from
3c04dcc to
16fa790
Compare
- Convert the Logic, MRML and MRMLDM modules to vtk.module - Add flag for VTK module auto init - Ensure extension and wheel builds works with a shared code base
- CI job does a single wheel build on Linux, Mac and Windows - Release job uses semantic release, build all wheels and upload to pypi
Could not find a proper way to apply generated patch. Doing the following: - `"build command" 2> report.txt` - `fix_include < report.txt` fails due to remove and add includes overlapping.
AlexyPellegrini
force-pushed
the
slicer-core-sdk-based
branch
from
16fa790 to
712dca8
Compare
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains required changes for the future slicer-core support.
It makes the project buildable using the slicer-core-sdk.