Draft
Conversation
this is helping bloat the maps, shrinking map size could help with speed, now failing on counting number of bytes per base address
with the zero-registers being skipped, the counts have changed
This reverts commit be61928.
there are so many ZS parameters that carrying around these maps (and the large set of values if dump/load "all" parameters is not needed) we can opt into include them again by undoing this change or (more likely) compilng the ZS parameters into registers offline and then loading those registers separately from other parameters
tomeichlersmith
commented
Mar 25, 2026
Comment on lines
-96
to
+97
| # if no bits used all bytes get n_bits=0 | ||
| return [f"RegisterLocation(0x{address + i:04x}, 0, 0)" for i in range(size_byte)] | ||
| # if no bits | ||
| return [] |
Member
Author
There was a problem hiding this comment.
@cmantill I'm curious on why you included these zero-bit register locations in the original mapping. Removing them allows the tests to pass with the only change to the tests being the base address -> number of bytes mapping for the test parameter set.
| f.write(',\n'.join( | ||
| ' {"%s", {%s::PAGE_LUT, %s::PARAMETER_LUT}}'%(rt,rt,rt) | ||
| for rt in all_types | ||
| for rt in all_types+["econd::with_zs"] |
Member
Author
There was a problem hiding this comment.
To Do:
- document what happens when I try to access a ZS parameter
- make sure I can do
pfcompile -t econd::with_zsas I think I can
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #266 by separating out the heavy/large ZS pages so we don't carry them around when doing normal interactions.
econd::with_zsand have the default LUTecondnot include the ZS