Skip to content

PR8: fix(inference): review follow-up in pipeline scripts#25

Closed
SergeiNikolenko wants to merge 2 commits intocodex/pr6a-inference-pipeline-fixfrom
codex/pr6b-inference-pipeline-refactor
Closed

PR8: fix(inference): review follow-up in pipeline scripts#25
SergeiNikolenko wants to merge 2 commits intocodex/pr6a-inference-pipeline-fixfrom
codex/pr6b-inference-pipeline-refactor

Conversation

@SergeiNikolenko
Copy link
Copy Markdown
Member

@SergeiNikolenko SergeiNikolenko commented Feb 26, 2026

Summary

This PR contains targeted inference-pipeline fixes requested in review, plus a final cleanup pass in the same script area.

No new features are added.

Review Issues Addressed

1) Checkpoint root mismatch in v2 inference pipeline

File: matcha/utils/inference_utils.py

Issue:

  • run_v2_inference_pipeline used conf.results_folder.
  • YAML configs generally expose checkpoints_folder.

Fix:

  • Added fallback resolution order:
    1. results_folder
    2. checkpoints_folder
  • Added explicit error if neither key is available.

2) Duplicate stage save / script cleanup

File: scripts/run_inference_pipeline.py

Issue:

  • duplicate stage-save behavior in legacy script path.

Fix:

  • removed duplicate save behavior,
  • simplified surrounding script logic in a follow-up cleanup.

File-Level Scope

  • matcha/utils/inference_utils.py
  • scripts/run_inference_pipeline.py

Quick Validation Command

uv run python scripts/run_inference_pipeline.py \
  -c configs/base.yaml \
  -p configs/default.yaml \
  -n pr8_pipeline_check \
  --n-samples 2

@SergeiNikolenko SergeiNikolenko force-pushed the codex/pr6a-inference-pipeline-fix branch from 2104c18 to 9d0adcc Compare February 26, 2026 15:55
@SergeiNikolenko SergeiNikolenko force-pushed the codex/pr6b-inference-pipeline-refactor branch from 9280c6a to 9747001 Compare February 26, 2026 15:55
- Fix double comment marker (# # → #)
- Remove dead commented-out code and duplicate loop line
- Remove extra blank line before __main__ guard
@SergeiNikolenko SergeiNikolenko force-pushed the codex/pr6b-inference-pipeline-refactor branch 2 times, most recently from 4d77841 to b864427 Compare February 28, 2026 20:43
@SergeiNikolenko SergeiNikolenko force-pushed the codex/pr6a-inference-pipeline-fix branch from ce154ef to c5ae26b Compare February 28, 2026 20:43
@SergeiNikolenko
Copy link
Copy Markdown
Member Author

Superseded by #33 (restacked on #32, no codex/ branch names).

@SergeiNikolenko SergeiNikolenko deleted the codex/pr6b-inference-pipeline-refactor branch March 5, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant