PR8: fix(inference): review follow-up in pipeline scripts#25
Closed
SergeiNikolenko wants to merge 2 commits intocodex/pr6a-inference-pipeline-fixfrom
Closed
PR8: fix(inference): review follow-up in pipeline scripts#25SergeiNikolenko wants to merge 2 commits intocodex/pr6a-inference-pipeline-fixfrom
SergeiNikolenko wants to merge 2 commits intocodex/pr6a-inference-pipeline-fixfrom
Conversation
2104c18 to
9d0adcc
Compare
9280c6a to
9747001
Compare
- Fix double comment marker (# # → #) - Remove dead commented-out code and duplicate loop line - Remove extra blank line before __main__ guard
4d77841 to
b864427
Compare
ce154ef to
c5ae26b
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains targeted inference-pipeline fixes requested in review, plus a final cleanup pass in the same script area.
No new features are added.
Review Issues Addressed
1) Checkpoint root mismatch in v2 inference pipeline
File:
matcha/utils/inference_utils.pyIssue:
run_v2_inference_pipelineusedconf.results_folder.checkpoints_folder.Fix:
results_foldercheckpoints_folder2) Duplicate stage save / script cleanup
File:
scripts/run_inference_pipeline.pyIssue:
Fix:
File-Level Scope
matcha/utils/inference_utils.pyscripts/run_inference_pipeline.pyQuick Validation Command