feat(conformers): isolated nvMolKit worker backend#40
Open
SergeiNikolenko wants to merge 5 commits intomainfrom
Open
feat(conformers): isolated nvMolKit worker backend#40SergeiNikolenko wants to merge 5 commits intomainfrom
SergeiNikolenko wants to merge 5 commits intomainfrom
Conversation
SergeiNikolenko
force-pushed
the
fix/scoring-followups
branch
from
8e0395a to
0993f2b
Compare
SergeiNikolenko
force-pushed
the
feat/nvmolkit-worker-backend
branch
from
ce15e1b to
b02f32a
Compare
Member
Author
|
Moved to fork and merged into |
- Extract _rdkit_generate_chunk() to eliminate 3x duplicated blocks - Consolidate max_failures/max_iterations into single max_attempts - Extract _conf_has_finite_coords predicate in worker CLI - Compact setup script: str.removeprefix(), f-strings, shorter docstrings - Remove 8 obvious/redundant comments
SergeiNikolenko
force-pushed
the
feat/nvmolkit-worker-backend
branch
from
b02f32a to
aa46ff9
Compare
SergeiNikolenko
force-pushed
the
fix/scoring-followups
branch
from
0993f2b to
023341d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #23.
What
.venv-nvmolkit-workerin auto mode when worker is missingMain changes
matcha/utils/preprocessing.pyautobackend modescripts/setup_nvmolkit_worker.py.venv-nvmolkit-workerpackages/matcha_nvmolkit_worker/...Why
This PR keeps the nvMolKit integration isolated from the main inference/scoring logic. Matcha can use a prepared GPU conformer worker when available, but still degrades safely to RDKit.
Validation
Optional worker setup check: