feat: Add autoPlayed funtionality for TeamParticipants#6872
feat: Add autoPlayed funtionality for TeamParticipants#6872
TeamParticipants#6872Conversation
TeamParticipants
Eetwalt
left a comment
There was a problem hiding this comment.
couple of typos, otherwise looks good to me
Co-authored-by: Eetu Rantanen <75437856+Eetwalt@users.noreply.github.com>
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
|
Will this lead to issues with data cycles or mismatches? |
the wikis this is (mostly) intended for (craft wikis) already store the players in match.match2opponents[X].match2players if they are set in a map even if they are not set in TC we currently already use a very similar logic on sc, sc2 and stormgate (only real diff is that instead of parent we use stages input, but implementing that for the new TC we would need to pass more stuff into settings and you wouldn't want to have to enter that per opponent...) additionally this functionality is to be enabled via a param (hence by default not enabled and not causing issues) and manual input always wins |
|
retested |
…ey are most likely finished in the event)
Summary
if
|autoplayed=trueis set in an opponent in theTeamParticipantstemplate it enables a lookup in match2 data which player actually played in any (team) matches of the tournament theTeamParticipantsis used for.Funnily enough this implementation would make import from match2 data for players quite easy too.
So if we want/need this at a later date the changes for that are minimal.
fwiw importing all teams from a toruanemt with their players from match2 without specifying any teams/players is basically not a good idea with how
TeamParticipantsstuff is set up...How did you test this change?
{{TeamParticipants|dev=hjp |{{Opponent|StreamerZone|autoplayed=true |players={{Persons |{{Person|sOs|role=captain}} |{{Person|Gerald}} |{{Person|LunaSea}} |{{Person|BabyMarine}} |{{Person|QuanTa}} |{{Person|Jumy}} |{{Person|NightMare}} }} }} }}on https://liquipedia.net/starcraft2/CranK_Gathers/Season_2