fix: rename ChunksHybridSearchRetriever and add embedding error handling#793
Open
Dayang26 wants to merge 2 commits intoMODSetter:mainfrom
Open
fix: rename ChunksHybridSearchRetriever and add embedding error handling#793Dayang26 wants to merge 2 commits intoMODSetter:mainfrom
Dayang26 wants to merge 2 commits intoMODSetter:mainfrom
Conversation
|
@Dayang26 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on d970688..cd82e78
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (2)
• surfsense_backend/app/retriever/chunks_hybrid_search.py
• surfsense_backend/app/services/connector_service.py
Owner
|
@Dayang26 Thanks. Can you please raise this PR on 'dev' branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the
ChunksHybridSearchRetrieverclass name and improves the robustness of the search functionality by adding error handling for embedding generation.Description
ChucksHybridSearchRetrievertoChunksHybridSearchRetrieverto fix the spelling error.embedding_model.embed(query_text)calls intry-exceptblocks withinvector_searchandhybrid_search.[]instead of crashing (or raisingUnboundLocalError) when the embedding model fails to generate embeddings.I didn't add a retry mechanism because I wanted to keep the changes minimal and avoid adding tenacity to pyproject.toml.
Motivation and Context
FIX #783
Screenshots
API Changes
Change Type
Testing Performed
Checklist
Close #783
High-level PR Summary
This PR corrects a typo in the class name from
ChucksHybridSearchRetrievertoChunksHybridSearchRetrieverand adds error handling to thevector_searchmethod. When embedding generation fails, the method now logs the error and returns an empty list instead of crashing, improving the robustness of the search functionality.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_backend/app/retriever/chunks_hybrid_search.pysurfsense_backend/app/services/connector_service.py