Remove drop level gap condition for jewels#697
Remove drop level gap condition for jewels#697ze-dom wants to merge 2 commits intoMUnique:masterfrom
Conversation
| } | ||
| else | ||
| { | ||
| filteredPossibleItems = [.. selectedGroup.PossibleItems.Where(it => it.DropLevel == 0 || (it.DropLevel <= monsterLevel && it.DropLevel > monsterLevel - 12))]; |
There was a problem hiding this comment.
That's a good question... I'm not sure if it is the correct value for all items. This would mean that Items can drop up to Level 5. If I remember correctly, this wasn't possible for all items. E.g. leather boots and gloves dropped until level 5, while other armor parts were limited to 3 or 4.
This 12 is btw at two places, it probably needs a constant, or to defined in ItemDefinition.
sven-n
left a comment
sven-n
left a comment
There was a problem hiding this comment.
Good and simple solution. I had a way more complicated solution in mind, but I like yours more 😅
Please just move this one method to the base class, instead of inheriting every class from Jewels.
| /// Initializer for pets. | ||
| /// </summary> | ||
| public class Pets : InitializerBase | ||
| public class Pets : Jewels |
There was a problem hiding this comment.
This looks strange. Can you move the AddItemToJewelItemDrop to InitializerBase instead?
|
Ok. What about the remarks in the PR description, what do you want to do about those? |
2 participants
Todo
This fix removes the drop level gap condition for Jewels, Imp, Angel, Uniria, Ale, and Town Portal Scroll, which was preventing these items from dropping by mobs with higher levels than that limit.
Remarks
Let me know your opinion on the following points, as to whether we should add them or not:
Apparently in zTeamS6.3, they moved the jewel item checks somewhere else and mobs didn't drop them. Maybe they sold them in NPC stores or something.