profsea-climate: Build custom models! #48
Draft
Greg Munday (gregrmunday) wants to merge 38 commits intoprofsea-climatefrom
Draft
profsea-climate: Build custom models! #48Greg Munday (gregrmunday) wants to merge 38 commits intoprofsea-climatefrom
profsea-climate: Build custom models! #48Greg Munday (gregrmunday) wants to merge 38 commits intoprofsea-climatefrom
Conversation
`profsea-climate-`v2`: Add Greenland
`profsea-climate-`v2`: landwater AR6 component
`profsea-climate-v2`: Add Global model save method
`profsea-climate-v2`: Add AR5 Antarctica components
`profsea-climate-v2`: Add AR5 Greenland components
`profsea-climate-v2`: Glacier component
Landwater AR5
`profsea-climate-v2`: Add thermal expansion component
Treatment of ensemble members vs single timeseries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking inspiration from SpeedyWeather.jl and Milan Klöwer (@milankl), this PR will restructure ProFSea so that users can build a particular model configuration as they choose using a simple Python script.
The gist is to disentangle each model component in the current code so that it can be used independently. Then, a user can put together a simple Python script where they import each model component they want to use, build their own configuration (or use an existing one) and compute projections.
For developers, this is extremely helpful because model component updates or additions are completely isolated to a specific file or block of code, making PRs much more easy to manage.
No science changes in this code, just code structure. Hemant Khatri (@hmkhatri) and I will produce PR's to be merged into this branch, ensuring each model component change is tested against results from the current structure. Eventually, we'll merge this branch into the 'main'
profsea-climatebranch.Example look at how someone would use ProFSea after this update: