fix: Estimate relay transactions separately and combine with original transaction gas at quote time#7933
Open
fix: Estimate relay transactions separately and combine with original transaction gas at quote time#7933
Conversation
packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts
Outdated
Show resolved
Hide resolved
1227b66 to
b895a33
Compare
b895a33 to
b17637e
Compare
packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
…essary code Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
…h submission, update changelog Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
da405bd to
e1cbc8b
Compare
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
…rom relay-submit.ts Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes fee/gas computation for post-quote Relay flows, which can impact quoted costs and batching behavior; scope is localized but touches transaction-cost accuracy across multiple edge cases.
Overview
Post-quote Relay quoting now estimates gas for Relay deposit transactions only, then adds the caller-provided original transaction gas into the returned totals at quote time (including updated
metamask.gasLimits,sourceNetworkestimate/max, and gas-fee-token amount calculations).The combination logic prefers
nestedTransactions[].gasovertxParams.gas, handles EIP-7702’s single combined batch limit by adding original gas into that single value, and removes the previoustoRelayParamspath that mixed the original tx into gas estimation. Tests and the changelog are updated to cover these post-quote scenarios and edge cases (missing gas, fallback estimates, EIP-7702).Written by Cursor Bugbot for commit d6c813e. This will update automatically on new commits. Configure here.