feat(kernel-browser-runtime): pass full RemoteCommsOptions via worker URL#881
Draft
feat(kernel-browser-runtime): pass full RemoteCommsOptions via worker URL#881
Conversation
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support passing all
RemoteCommsOptions(relays, allowedWsHosts, directListenAddresses, numeric options, mnemonic) into the kernel worker via the worker URL, instead of only relays.Changes
comms-query-string utilities
RemoteCommsOptions(excludingdirectTransports)ARRAY_PARAM_NAMESandNUMBER_PARAM_NAMESare derived fromRemoteCommsOptionscreateCommsQueryStringnow returnsURLSearchParamsso callers can append params (e.g.reset-storage,system-subclusters) before settingURL.searchparseRelayQueryString,parseAllowedWsHostsQueryString, andgetRelaysFromCurrentLocation; usegetCommsParamsFromCurrentLocation()andparseCommsQueryString()insteadmakeKernelWorker (extension & omnium-gatherum)
remoteCommsOptions?: Partial<RemoteCommsOptions>as the first argumentcreateCommsQueryStringDEFAULT_RELAYSwhen no options are providedkernel-worker
getCommsParamsFromCurrentLocation()and passes them tokernel.initRemoteComms()Usage