feat: Add Horizon-based transaction tracking and keyring settlement for trustline operation status tracking#51
Open
feat: Add Horizon-based transaction tracking and keyring settlement for trustline operation status tracking#51
Conversation
khanti42
changed the title
| ); | ||
| try { | ||
| const lastStatus = | ||
| await this.#networkService.getHorizonTransactionInclusionStatus( |
Collaborator
There was a problem hiding this comment.
shall we get it from RPC -> poll transaction? (try to use rpc if possible)
another question, if attempt >= TRACK_TRANSACTION_MAX_ATTEMPTS, why we need to track once again?
Collaborator
There was a problem hiding this comment.
if we choose to use pollTransaction (from RPC) (20 seconds)
we just need to try catch the function, and verify if there is a TransactionPollException, and choose what action to take against the status on the TransactionPollException
if it is unknown -> rpc down
| TrackTransactionHandler.duration, | ||
| ); | ||
| } else { | ||
| await synchronizeAccounts(); |
Collaborator
There was a problem hiding this comment.
we can use background job (TBC)
unique the account ids before sending request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist