added AGC demo design#33
Open
elizabethjt wants to merge 14 commits intomainfrom
Open
Conversation
- Default value (GBRG) for bayer format argument was removed from DeBayer function. Now users need to explicitly pass the required format. This will hopefully prevent unexpected mismatches. - Added bayer format argument to RGBBayer function. - Added new function BGR2Bayer to make it easier to just process images loaded with OpenCV without having to convert the color. - Updated Bayer-DeBayer example using the above changes. - Updated golden images for Bayer and Debayer test. - Added two new variations to TransformPixel function. One where the "ij" pixel coordinates is passed to the functor argument, and the other where an "enable" argument is passed to the functor argument. This will provide more info to process pixels. - Added new method ConvertTo() the Img class. This is similar to OpenCV's function to scale and add factors to pixels of an image. - Add .gitignore
- Also added the example designs for testing each function. - For the GammaCorrection function, a table generator has been added. This is a temporary solution until we can generate tables at compile time. - Also updated the .gitignore file
The demo now has a PASS/FAIL check against a golden image. Even though the demo is meant to be used for video, a test with a single image can at least check if the verilog code would work for one frame. The check also has a flag (SMALL) to select a small image for quick cosim testing. If this flag is not set (Default) a 4K image is used.
Makefile has been updated and run_libero.ps1 has been added
- Updated readme - Updated .hex file with additional printout - Modified gdb.txt to load the .elf, start the execution and quit. - SW makefile now always updates the .hex file that Libero uses to compile the bitstream
The update includes the commands to: 1. Compile the SmartHLS module and generate Verilog and the C++ API 2. Compile the software for the Soft-MiV RV32 CPU 3. Compile the Libero project
- Also removed extra ip_core_versions.tcl file. Only one is used now, under rtl directory.
… version from 2.1.110 to 2.1.113 to resolve the libero generation failure.
- updated core versions to build with libero 2025.2
ManuelSaldana
requested changes
May 5, 2026
Collaborator
ManuelSaldana
left a comment
ManuelSaldana
left a comment
There was a problem hiding this comment.
The current gamma correction and image enhance from main branch are more up to date than the versions coming from the PR. The current versions should work for the AGC demo. Please double check that's the case.
Collaborator
There was a problem hiding this comment.
This generator may not be necessary if the AGC demo works with the gamma correction version from main branch.
Collaborator
There was a problem hiding this comment.
The IP core version upgrade also affects the PFVideo_Kit demo design, not just the AGC demo. Please confirm that the former also compiles and works on-board.
Collaborator
|
Some minor nitpicks (none of which would really stop this PR from going in.) |
Collaborator
There was a problem hiding this comment.
Ideally we'd also have a Linux run_libero script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.