Draft
Conversation
Migrate typing annotations to built-in generics (list, dict, etc.) and tidy imports across the codebase for Python 3.9+ compatibility. Updated various modules to replace typing.List/Dict/Type/Iterator with modern equivalents, adjusted some Optional and Union hints, and simplified imports. Added [tool.ruff] target-version = "py39" to pyproject.toml. Also tightened tests: assert recurring_id presence and use identity check for boolean in an assertion.
Update pyproject.toml to require pylint ^3.3.0 and regenerate poetry.lock (Poetry 2.2.1) to lock the updated dependencies. This ensures dev tooling uses the newer pylint release and related dependency constraints are refreshed.
Move and consolidate the [tool.ruff] block in pyproject.toml (add target-version = "py39" and remove duplicate section). Update DecimalAmount.validator signature to use a string forward reference for cls ("DecimalAmount") instead of type[...] to avoid typing/forward-reference issues on Python 3.9 and keep annotations consistet.
Declare requests (^2.32.3) and urllib3 (^2.2.2) in pyproject.toml. Update poetry.lock to reflect the added dependencies and their metadata (charset-normalizer/requests/urllib3 set to non-optional and assigned to main and dev groups), and refresh the lockfile content hash.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 90.62% 90.77% +0.15%
==========================================
Files 144 147 +3
Lines 2539 2581 +42
==========================================
+ Hits 2301 2343 +42
Misses 238 238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor to the SDK's HTTP transport layer, decoupling the SDK from specific HTTP client libraries and enabling flexible transport injection. The changes implement a new abstraction for HTTP communication, update the client and SDK classes to use this abstraction, and provide examples for integrating with multiple HTTP clients (
requests,httpx, andurllib3). The project dependency configuration is also updated to support optional transports.Transport Layer Abstraction and Integration
HTTPTransportandHTTPResponseprotocol interfaces insrc/multisafepay/transport/http_transport.pyto abstract HTTP communication and response handling, enabling the SDK to work with any compatible HTTP client.ClientandSdkclasses to accept atransportparameter instead of a concrete HTTP client, defaulting toRequestsTransportif none is provided. All request logic now uses the transport abstraction. [1] [2] [3] [4] [5] [6] [7]Example Implementations for Multiple HTTP Clients
httpxandurllib3, demonstrating how to inject custom transport implementations and adapt responses to the SDK interface. Therequest_transport.pyexample shows advancedrequests.Sessionusage with retry and connection pooling. [1] [2] [3]Dependency Management and Configuration
pyproject.tomlto moverequestsandurllib3to an optional extra, allowing users to install only the transports they need. Development dependencies now includepython-dotenv,requests,urllib3, andhttpxfor example and test support. [1] [2]Module Structure and Exports
src/multisafepay/transport/__init__.pyto define the transport module's public API and ensure proper import and discoverability.src/multisafepay/__init__.pyto clarify exports.These changes make the SDK more flexible, testable, and extensible for users who want to use different HTTP clients or custom transport logic.